[PATCH] list: Fix order of arguments for hlist_add_after(_rcu)
Paul E. McKenney
paulmck at linux.vnet.ibm.com
Fri Jun 6 10:22:51 PDT 2014
On Fri, Jun 06, 2014 at 03:56:52PM +0000, David Laight wrote:
> From: Behalf Of Ken Helias
> > All other add functions for lists have the new item as first argument and the
> > position where it is added as second argument. This was changed for no good
> > reason in this function and makes using it unnecessary confusing.
> >
> > Also the naming of the arguments in hlist_add_after was confusing. It was
> > changed to use the same names as hlist_add_after_rcu.
> ...
> > -static inline void hlist_add_after_rcu(struct hlist_node *prev,
> > - struct hlist_node *n)
> > +static inline void hlist_add_after_rcu(struct hlist_node *n,
> > + struct hlist_node *prev)
>
> It is rather a shame that the change doesn't generate a compilation
> error for old source files.
I am also a bit concerned by this.
Thanx, Paul
More information about the dri-devel
mailing list