[PATCH v2 2/3] exynos: fix G2D_DOUBLE_TO_FIXED for non-integer input

Inki Dae inki.dae at samsung.com
Thu Jun 12 22:05:41 PDT 2014


On 2014년 06월 02일 01:04, Tobias Jakobi wrote:
> The hardware accepts scaling factors formatted in a
> fixed-point format. The current macro casts to integer
> first, then multiplies by the fp conversion factor.
> 
> This does not make any sense. In particular, truly
> 'fractional' inputs, like 1.5, won't work that way.

Signed-off-by: Inki Dae <inki.dae at samsung.com>

Thanks,
Inki Dae

> 
> Signed-off-by: Tobias Jakobi <tjakobi at math.uni-bielefeld.de>
> ---
>  exynos/fimg2d.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/exynos/fimg2d.h b/exynos/fimg2d.h
> index 1aac378..4785e2f 100644
> --- a/exynos/fimg2d.h
> +++ b/exynos/fimg2d.h
> @@ -25,7 +25,7 @@
>  #define G2D_MAX_CMD_LIST_NR	64
>  #define G2D_PLANE_MAX_NR	2
>  
> -#define G2D_DOUBLE_TO_FIXED(d)		((unsigned int)(d) * 65536.0)
> +#define G2D_DOUBLE_TO_FIXED(d)		((unsigned int)((d) * 65536.0))
>  
>  enum e_g2d_color_mode {
>  	/* COLOR FORMAT */
> 



More information about the dri-devel mailing list