[RFCv2 05/10] drm: Add plane type property

Matt Roper matthew.d.roper at intel.com
Wed Mar 12 09:43:11 PDT 2014


On Tue, Mar 11, 2014 at 04:45:00PM -0700, Bob Paauwe wrote:
> On Fri, 7 Mar 2014 16:03:17 -0800
> Matt Roper <matthew.d.roper at intel.com> wrote:
...
> > +static int drm_mode_create_standard_plane_properties(struct drm_device *dev)
> > +{
> > +	struct drm_property *type;
> > +
> > +	/*
> > +	 * Standard properties (apply to all planes)
> > +	 */
> > +	type = drm_property_create_enum(dev, 0,
> > +					"TYPE", drm_plane_type_enum_list,
> > +					ARRAY_SIZE(drm_plane_type_enum_list));
> 
> Should this property be created with DRM_MODE_PROP_IMMUTABLE set?  What
> happens if user space tries to change this property to a different type?
> 

Yep, good point.  I'll add that flag in my next revision of the
patchset.

Thanks!


Matt

-- 
Matt Roper
Graphics Software Engineer
ISG Platform Enabling & Development
Intel Corporation
(916) 356-2795


More information about the dri-devel mailing list