[PATCH 1/3] nouveau: cleanup error handling during nouveau_device_wrap

Ilia Mirkin imirkin at alum.mit.edu
Wed Mar 12 18:27:16 PDT 2014


On Wed, Mar 12, 2014 at 9:24 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 13/03/14 01:05, Ilia Mirkin wrote:
> [snip]
>
>>
>> Not really. drm->drm_version will be 0 if ver fails.
>>
> Indeed, dev is calloc'ated by its callers, and if they mess around with
> that's their own fault.

The callers? It's calloc'd inside nouveau_device_wrap itself. Unless
calloc is changed to not init to 0 (which would be a giant spec
violation), I don't see how something could go wrong.


More information about the dri-devel mailing list