[PATCH 00/11] A few patches around DRM logging

[Patrik Jakobsson]

On Mon, Mar 24, 2014 at 4:53 PM, Damien Lespiau <damien.lespiau at intel.com>wrote:

> As patch 8/11 explains, I noticed that we where evaluating the arguments to
> drm_ut_debug_printk() even when drm.debug was 0, doing some work for no
> good
> reason. By pulling the test on drm_debug before calling
> drm_ut_debug_printk(),
> we skip those instructions that only need to be executed when logging is
> on.
>
> The remaining patches are bonus clean-ups, with the main goal of removing
> DRM_LOG* macros that are not really used throughout the code base. After
> that,
> it's possible to simplify a bit drm_ut_debug_printk(). All pretty
> straightforward cleanups, but still worthwhile IMHO.
>
> For driver-specific patches (why some of you are Cced in that series), I'd
> love
> if you could take the time to throw a Acked-by/Reviewed-by tag. Also, do
> you
> have any objection if the driver specific patch go through the DRM tree?
> should people judge that series worthwhile, of course.
>
>
I'm ok with this going through the DRM tree.

Reviewed-by: Patrik Jakobsson <patrik.r.jakobsson at gmail.com>


> --
> Damien
>
> Damien Lespiau (11):
>   drm: Refresh the explanation of debug categories
>   drm: Remove the unused (and unusable) DRM_LOG_MODE()
>   drm/exynos: Replace DRM_LOG_KMS() by DRM_DEBUG_KMS()
>   drm/gma500: Replace DRM_LOG_KMS() by DRM_DEBUG_KMS()
>   drm/i915: Replace DRM_LOG_KMS() by DRM_DEBUG_KMS()
>   staging: imx-drm: Replace DRM_LOG_KMS() by DRM_DEBUG_KMS()
>   drm: Remove the now unused DRM_LOG* macros
>   drm: Pull the test on drm_debug in the logging macros
>   drm: drm_ut_debug_printk() isn't called with NULL anywmore
>   drm: Remove the prefix argument of drm_ut_debug_printk()
>   drm: Remove the ',' after the function name in debug logs
>
>  drivers/gpu/drm/drm_stub.c                |  24 +++----
>  drivers/gpu/drm/exynos/exynos_drm_fbdev.c |   2 +-
>  drivers/gpu/drm/exynos/exynos_drm_plane.c |   2 +-
>  drivers/gpu/drm/gma500/psb_intel_sdvo.c   |  20 +++---
>  drivers/gpu/drm/i915/dvo_ch7xxx.c         |   4 +-
>  drivers/gpu/drm/i915/dvo_ivch.c           |  30 ++++-----
>  drivers/gpu/drm/i915/dvo_ns2501.c         |  10 +--
>  drivers/gpu/drm/i915/dvo_sil164.c         |  10 +--
>  drivers/gpu/drm/i915/dvo_tfp410.c         |  24 +++----
>  drivers/staging/imx-drm/ipuv3-plane.c     |   2 +-
>  include/drm/drmP.h                        | 106
> +++++++++++-------------------
>  11 files changed, 98 insertions(+), 136 deletions(-)
>
> --
> 1.8.3.1
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140325/3ad2b851/attachment.html>