[PATCH 06/16] drm: Protect the master management with a drm_device::master_mutex v3

David Herrmann dh.herrmann at gmail.com
Fri Mar 28 04:23:17 PDT 2014


Hi

On Fri, Mar 28, 2014 at 10:34 AM, Thomas Hellstrom
<thellstrom at vmware.com> wrote:
> The master management was previously protected by the drm_device::struct_mutex.
> In order to avoid locking order violations in a reworked dropped master
> security check in the vmwgfx driver, break it out into a separate master_mutex.
> Locking order is master_mutex -> struct_mutex.
>
> Also remove drm_master::blocked since it's not used.
>
> v2: Add an inline comment about what drm_device::master_mutex is protecting.
> v3: Remove unneeded struct_mutex locks. Fix error returns in
>     drm_setmaster_ioctl().

Thanks, looks much better now. Tested on hsw, so I'm fine with pushing
this into 3.15.

Thanks
David


More information about the dri-devel mailing list