[PATCH 2/4] drm/ttm: Add optional support for two-ended allocation

Lucas Stach l.stach at pengutronix.de
Mon Mar 31 08:08:42 PDT 2014


Am Montag, den 31.03.2014, 17:51 +0300 schrieb Lauri Kasanen:
> On Mon, 31 Mar 2014 14:41:05 +0200
> Lucas Stach <l.stach at pengutronix.de> wrote:
> 
> > Am Montag, den 31.03.2014, 15:28 +0300 schrieb Lauri Kasanen:
> > > Allocating small bos from one end and large ones from the other helps
> > > improve the quality of fragmentation.
> > > 
> > > This depends on "drm: Optionally create mm blocks from top-to-bottom" by
> > > Chris Wilson.
> > > 
> > You are breaking bisectability here. This patch deliberately introduces
> > a build failure that you only fix up in the next two patches. This isn't
> > acceptable, you must squash the following patches in to avoid the
> > breakage.
> > 
> > Also if the first patch is from Chris Wilson and you only did some small
> > changes this should be reflected in the author name of the patch.
> 
> OK, will squash and resend. Then the changes are mostly mine in the
> singular patch.
> 
> BTW, how would I handle the case of a different author, when I cannot
> use git-send-email due to network mail restrictions? I can't send email
> from an address I don't own.
> 
You should send it from your address, but start the patch description
with a line "From: Original Author <original at author.bla>", so git picks
up the proper authorship. Git send-email does this the same way.

Regards,
Lucas

-- 
Pengutronix e.K.                           | Lucas Stach                 |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the dri-devel mailing list