[Intel-gfx] [PATCH 1/4] drm: Support legacy cursor ioctls via universal planes when possible (v2)

Daniel Vetter daniel at ffwll.ch
Mon May 19 00:28:35 PDT 2014


I didn't spot anything else, so with the below issue addressed this patch
is Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>

On Sat, May 17, 2014 at 12:43:04AM +0200, Daniel Vetter wrote:
> On Sat, May 17, 2014 at 12:38 AM, Matt Roper <matthew.d.roper at intel.com> wrote:
> > +       if (ret) {
> > +               if (req->flags & DRM_MODE_CURSOR_BO)
> > +                       drm_mode_rmfb(dev, &fb->base.id, file_priv);
> > +               return ret;
> > +       }
> 
> With the new refcount logic an unconditional
> drm_framebuffer_unreference should be here instead of this. I think,
> but please double-check since it's late here ;-)
> -Daniel
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dri-devel mailing list