[PATCH] drm/rcar-du: Add run-time dependencies

[Jean Delvare]

Hi Laurent,

On Mon, 26 May 2014 13:36:11 +0200, Laurent Pinchart wrote:
> Thank you for the patch.

You're welcome. And thanks for your help :-)

> On Monday 26 May 2014 13:01:35 Jean Delvare wrote:
> > The Renesas R-Car Display Unit driver is only useful on shmobile
> > unless build testing. The LVDS output is useful on an even more
> > reduced hardware set.
> > 
> > Signed-off-by: Jean Delvare <jdelvare at suse.de>
> > Cc: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>
> > Cc: David Airlie <airlied at linux.ie>
> > ---
> >  drivers/gpu/drm/rcar-du/Kconfig |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > --- linux-3.15-rc6.orig/drivers/gpu/drm/rcar-du/Kconfig	2014-03-31
> > 05:40:15.000000000 +0200 +++
> > linux-3.15-rc6/drivers/gpu/drm/rcar-du/Kconfig	2014-05-23
> > 18:03:16.440036942 +0200 @@ -1,6 +1,7 @@
> >  config DRM_RCAR_DU
> >  	tristate "DRM Support for R-Car Display Unit"
> >  	depends on DRM && ARM
> 
> Have you checked whether ARM is needed for compilation ? If not you could drop 
> it.

It does depend on ARM indirectly, because it selects DRM_GEM_CMA_HELPER
which builds code that calls dma_alloc_writecombine(), which in turn is
only defined on arm (and avr32.) That's why I left the build-time
dependency on ARM.

> 
> > +	depends on ARCH_SHMOBILE || COMPILE_TEST
> >  	select DRM_KMS_HELPER
> >  	select DRM_KMS_CMA_HELPER
> >  	select DRM_GEM_CMA_HELPER
> > @@ -12,6 +13,7 @@ config DRM_RCAR_DU
> >  config DRM_RCAR_LVDS
> >  	bool "R-Car DU LVDS Encoder Support"
> >  	depends on DRM_RCAR_DU
> > +	depends on ARCH_R8A7790 || ARCH_R8A7791 || COMPILE_TEST
> >  	help
> >  	  Enable support the R-Car Display Unit embedded LVDS encoders
> >  	  (currently only on R8A7790).


-- 
Jean Delvare
SUSE L3 Support