[PATCH 13/18] drm/edid: Use kmemdup instead of kmalloc + memcpy

[Jani Nikula]

On Mon, 26 May 2014, Benoit Taine <benoit.taine at lip6.fr> wrote:
> This issue was reported by coccicheck using the semantic patch 
> at scripts/coccinelle/api/memdup.cocci

Reviewed-by: Jani Nikula <jani.nikula at intel.com>


>
> Signed-off-by: Benoit Taine <benoit.taine at lip6.fr>
> ---
> Tested by compilation without errors.
>
>  drivers/gpu/drm/drm_edid.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 7a4fd2e..d74239f 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -3228,10 +3228,9 @@ int drm_edid_to_speaker_allocation(struct edid *edid, u8 **sadb)
>  
>  			/* Speaker Allocation Data Block */
>  			if (dbl == 3) {
> -				*sadb = kmalloc(dbl, GFP_KERNEL);
> +				*sadb = kmemdup(&db[1], dbl, GFP_KERNEL);
>  				if (!*sadb)
>  					return -ENOMEM;
> -				memcpy(*sadb, &db[1], dbl);
>  				count = dbl;
>  				break;
>  			}
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Jani Nikula, Intel Open Source Technology Center