[PATCH 0/7] drm: Sanitize DRM_IOCTL_MODE_CREATE_DUMB input
Russell King - ARM Linux
linux at arm.linux.org.uk
Wed Nov 5 06:24:42 PST 2014
On Wed, Nov 05, 2014 at 02:25:12PM +0100, Thierry Reding wrote:
> Discussion on IRC lead to the conclusion that new IOCTLs should have
> input validation and require userspace to zero out output parameters to
> avoid this kind of mess in the future. In order to help avoid this kind
> of ambiguity it would be a good idea to start documenting IOCTLs more
> officially (e.g. in the DRM DocBook).
That is a good point, however not everyone can build the documentation.
I tried a while back and the whole documentation subsystem is /soo/
fragile its untrue. You have to have the exact right versions installed
and hope that the exact right versions have configured themselves to
work together correctly, otherwise you get cryptic unsolvable error
messages. Tex is notorious for these problems.
When I tried to generate the docbook stuff, after spending a significant
amount of time trying to debug it, I just gave up completely with any
ideas about ever adding to the documentation. I've since decided that
I am /never/ going to do anything past adding docbook comments to files.
If someone cares about linking them into the rest of the docbook system,
and they have the capability to generate the docbook output, then that's
fine and dandy, but I believe that requiring everyone to have that
capability is asking far too much.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
More information about the dri-devel
mailing list