[Bug 87891] New: kernel BUG at mm/slab.c:2625!
Andrew Morton
akpm at linux-foundation.org
Tue Nov 11 15:31:20 PST 2014
(switched to email. Please respond via emailed reply-to-all, not via the
bugzilla web interface).
On Thu, 06 Nov 2014 17:28:41 +0000 bugzilla-daemon at bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=87891
>
> Bug ID: 87891
> Summary: kernel BUG at mm/slab.c:2625!
> Product: Memory Management
> Version: 2.5
> Kernel Version: 3.17.2
> Hardware: i386
> OS: Linux
> Tree: Mainline
> Status: NEW
> Severity: blocking
> Priority: P1
> Component: Slab Allocator
> Assignee: akpm at linux-foundation.org
> Reporter: luke-jr+linuxbugs at utopios.org
> Regression: No
Well this is interesting.
> [359782.842112] kernel BUG at mm/slab.c:2625!
> ...
> [359782.843008] Call Trace:
> [359782.843017] [<ffffffff8115181f>] __kmalloc+0xdf/0x200
> [359782.843037] [<ffffffffa0466285>] ? ttm_page_pool_free+0x35/0x180 [ttm]
> [359782.843060] [<ffffffffa0466285>] ttm_page_pool_free+0x35/0x180 [ttm]
> [359782.843084] [<ffffffffa046674e>] ttm_pool_shrink_scan+0xae/0xd0 [ttm]
> [359782.843108] [<ffffffff8111c2fb>] shrink_slab_node+0x12b/0x2e0
> [359782.843129] [<ffffffff81127ed4>] ? fragmentation_index+0x14/0x70
> [359782.843150] [<ffffffff8110fc3a>] ? zone_watermark_ok+0x1a/0x20
> [359782.843171] [<ffffffff8111ceb8>] shrink_slab+0xc8/0x110
> [359782.843189] [<ffffffff81120480>] do_try_to_free_pages+0x300/0x410
> [359782.843210] [<ffffffff8112084b>] try_to_free_pages+0xbb/0x190
> [359782.843230] [<ffffffff81113136>] __alloc_pages_nodemask+0x696/0xa90
> [359782.843253] [<ffffffff8115810a>] do_huge_pmd_anonymous_page+0xfa/0x3f0
> [359782.843278] [<ffffffff812dffe7>] ? debug_smp_processor_id+0x17/0x20
> [359782.843300] [<ffffffff81118dc7>] ? __lru_cache_add+0x57/0xa0
> [359782.843321] [<ffffffff811385ce>] handle_mm_fault+0x37e/0xdd0
It went pagefault
->__alloc_pages_nodemask
->shrink_slab
->ttm_pool_shrink_scan
->ttm_page_pool_free
->kmalloc
->cache_grow
->BUG_ON(flags & GFP_SLAB_BUG_MASK);
And I don't really know why - I'm not seeing anything in there which
can set a GFP flag which is outside GFP_SLAB_BUG_MASK. However I see
lots of nits.
Core MM:
__alloc_pages_nodemask() does
if (unlikely(!page)) {
/*
* Runtime PM, block IO and its error handling path
* can deadlock because I/O on the device might not
* complete.
*/
gfp_mask = memalloc_noio_flags(gfp_mask);
page = __alloc_pages_slowpath(gfp_mask, order,
zonelist, high_zoneidx, nodemask,
preferred_zone, classzone_idx, migratetype);
}
so it permanently alters the value of incoming arg gfp_mask. This
means that the following trace_mm_page_alloc() will print the wrong
value of gfp_mask, and if we later do the `goto retry_cpuset', we retry
with a possibly different gfp_mask. Isn't this a bug?
Also, why are we even passing a gfp_t down to the shrinkers? So they
can work out the allocation context - things like __GFP_IO, __GFP_FS,
etc? Is it even appropriate to use that mask for a new allocation
attempt within a particular shrinker?
ttm:
I think it's a bad idea to be calling kmalloc() in the slab shrinker
function. We *know* that the system is low on memory and is trying to
free things up. Trying to allocate *more* memory at this time is
asking for trouble. ttm_page_pool_free() could easily be tweaked to
use a fixed-size local array of page*'s t avoid that allocation. Could
someone implement this please?
slab:
There's no point in doing
#define GFP_SLAB_BUG_MASK (__GFP_DMA32|__GFP_HIGHMEM|~__GFP_BITS_MASK)
because __GFP_DMA32|__GFP_HIGHMEM are already part of ~__GFP_BITS_MASK.
What's it trying to do here?
And it's quite infuriating to go BUG when the code could easily warn
and fix it up.
And it's quite infuriating to go BUG because one of the bits was set,
but not tell us which bit it was!
Could the slab guys please review this?
From: Andrew Morton <akpm at linux-foundation.org>
Subject: slab: improve checking for invalid gfp_flags
- The code goes BUG, but doesn't tell us which bits were unexpectedly
set. Print that out.
- The code goes BUG when it could jsut fix things up and proceed. Do that.
- ~__GFP_BITS_MASK already includes __GFP_DMA32 and __GFP_HIGHMEM, so
remove those from the GFP_SLAB_BUG_MASK definition.
Cc: Christoph Lameter <cl at linux.com>
Cc: Pekka Enberg <penberg at kernel.org>
Cc: David Rientjes <rientjes at google.com>
Cc: Joonsoo Kim <iamjoonsoo.kim at lge.com>
Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
---
include/linux/gfp.h | 2 +-
mm/slab.c | 5 ++++-
mm/slub.c | 5 ++++-
3 files changed, 9 insertions(+), 3 deletions(-)
diff -puN include/linux/gfp.h~slab-improve-checking-for-invalid-gfp_flags include/linux/gfp.h
--- a/include/linux/gfp.h~slab-improve-checking-for-invalid-gfp_flags
+++ a/include/linux/gfp.h
@@ -145,7 +145,7 @@ struct vm_area_struct;
#define GFP_CONSTRAINT_MASK (__GFP_HARDWALL|__GFP_THISNODE)
/* Do not use these with a slab allocator */
-#define GFP_SLAB_BUG_MASK (__GFP_DMA32|__GFP_HIGHMEM|~__GFP_BITS_MASK)
+#define GFP_SLAB_BUG_MASK (~__GFP_BITS_MASK)
/* Flag - indicates that the buffer will be suitable for DMA. Ignored on some
platforms, used as appropriate on others */
diff -puN mm/slab.c~slab-improve-checking-for-invalid-gfp_flags mm/slab.c
--- a/mm/slab.c~slab-improve-checking-for-invalid-gfp_flags
+++ a/mm/slab.c
@@ -2590,7 +2590,10 @@ static int cache_grow(struct kmem_cache
* Be lazy and only check for valid flags here, keeping it out of the
* critical path in kmem_cache_alloc().
*/
- BUG_ON(flags & GFP_SLAB_BUG_MASK);
+ if (WARN_ON(flags & GFP_SLAB_BUG_MASK)) {
+ pr_emerg("gfp: %u\n", flags & GFP_SLAB_BUG_MASK);
+ flags &= ~GFP_SLAB_BUG_MASK;
+ }
local_flags = flags & (GFP_CONSTRAINT_MASK|GFP_RECLAIM_MASK);
/* Take the node list lock to change the colour_next on this node */
diff -puN mm/slub.c~slab-improve-checking-for-invalid-gfp_flags mm/slub.c
--- a/mm/slub.c~slab-improve-checking-for-invalid-gfp_flags
+++ a/mm/slub.c
@@ -1377,7 +1377,10 @@ static struct page *new_slab(struct kmem
int order;
int idx;
- BUG_ON(flags & GFP_SLAB_BUG_MASK);
+ if (WARN_ON(flags & GFP_SLAB_BUG_MASK)) {
+ pr_emerg("gfp: %u\n", flags & GFP_SLAB_BUG_MASK);
+ flags &= ~GFP_SLAB_BUG_MASK;
+ }
page = allocate_slab(s,
flags & (GFP_RECLAIM_MASK | GFP_CONSTRAINT_MASK), node);
_
More information about the dri-devel
mailing list