[RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init

Gustavo Padovan gustavo at padovan.org
Tue Nov 18 12:28:36 PST 2014


2014-11-18 Kevin Hilman <khilman at kernel.org>:

> Javier Martinez Canillas <javier.martinez at collabora.co.uk> writes:
> 
> > The Exynos DRM driver register its sub-devices platform drivers in
> > the probe function but after commit 43c0767 ("of/platform: Move
> > platform devices under /sys/devices/platform"), this is causing
> > a deadlock in __driver_attach(). Fix this by moving the platform
> > drivers registration to exynos_drm_init().
> >
> > Suggested-by: Andrzej Hajda <a.hajda at samsung.com>
> > Signed-off-by: Javier Martinez Canillas <javier.martinez at collabora.co.uk>
> > ---
> >
> > This issue was reported by both Krzysztof Kozlowski [0] and Kevin Hilman [1].
> >
> > Inki Dae said that he will fix it property by separating the Exynos DRM
> > driver in different sub-modules but I post this patch as RFC anyways so
> > others can test if this fixes their boot issue.
> 
> It fixes the DRM deadlock, issue for me on exynos5800-peach-pi, but then
> it proceeds to panic in the workqueue code called by the asoc max98090
> codec[1].
> 
> If I then disable CONFIG_SND_SOC_SNOW, I can get it to boot to a shell,
> but I still don't have display output.
> 
> Is anyone at Samsung testing linux-next?  If so, on what platforms?  It
> would really be nice if your linux-next work was tested on these
> publically-available 542x/5800 platforms (peach-pi, peach-pit,
> odroid-xu3) which would also allow lots of others to help you test and
> validate.

It would also be good to add drm-exynos-next to the daily linux-next build.
Currently drm-exynos-next is ahead of linux-next. This patch from Javier for
example only applies on linux-next.

	Gustavo


More information about the dri-devel mailing list