[PATCH v2] drm/tilcdc: add missing clk_put in tilcdc_unload()

Julien CHAUVEAU julien.chauveau at neo-technologies.fr
Wed Nov 19 06:56:46 PST 2014


We need to call clk_put on display clock, in the same way as functional clock.
Also remove the check for priv->clk, since clk_put() is safe against NULL pointers.

Signed-off-by: Julien CHAUVEAU <julien.chauveau at neo-technologies.fr>
---
Changes since v1:
- remove the check for priv->clk, as suggested by Felipe Balbi

 drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 79a34cb..b0c9687 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -136,8 +136,8 @@ static int tilcdc_unload(struct drm_device *dev)
 			CPUFREQ_TRANSITION_NOTIFIER);
 #endif
 
-	if (priv->clk)
-		clk_put(priv->clk);
+	clk_put(priv->disp_clk);
+	clk_put(priv->clk);
 
 	if (priv->mmio)
 		iounmap(priv->mmio);
-- 
2.1.0



More information about the dri-devel mailing list