[PATCH] drivers:gpu:qlx: Change incorrect return value of EINVAL to ENODEV in qxl_drv.c

Nicholas Krause xerofoify at gmail.com
Fri Nov 21 13:29:58 PST 2014


Fixes not returning correct error code value in qxl_drv.c for the function,
qxl_pci_probe as this is a error with the device rather then an incorrect
value as stated by the DRM_ERROR statement above the return if this function
returns a error.
Signed-off-by: Nicholas Krause <xerofoify at gmail.com>
---
 drivers/gpu/drm/qxl/qxl_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/qxl/qxl_drv.c b/drivers/gpu/drm/qxl/qxl_drv.c
index 1d9b80c..bbe2a34 100644
--- a/drivers/gpu/drm/qxl/qxl_drv.c
+++ b/drivers/gpu/drm/qxl/qxl_drv.c
@@ -65,7 +65,7 @@ qxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	if (pdev->revision < 4) {
 		DRM_ERROR("qxl too old, doesn't support client_monitors_config,"
 			  " use xf86-video-qxl in user mode");
-		return -EINVAL; /* TODO: ENODEV ? */
+		return -ENODEV;
 	}
 	return drm_get_pci_dev(pdev, ent, &qxl_driver);
 }
-- 
1.9.1



More information about the dri-devel mailing list