[Bug 82889] [drm:si_dpm_set_power_state] *ERROR* si_disable_ulv failed

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=82889

--- Comment #18 from Alexandre Demers <alexandre.f.demers at gmail.com> ---
(In reply to Alex Deucher from comment #17)
> Created attachment 107784 [details] [review]
> disable ulv state on SI
> 
> (In reply to Alexandre Demers from comment #16)
> > Alex, I think this "ERROR" should be at most a warning: I've been commenting
> > out the "return ret" when we hit the error, and everything else goes as
> > smooth as possible.
> > 
> > Also, do you have any clue on the way we should dig to understand why we are
> > hitting this error? As said by Samir, this appeared with dpm.
> 
> It's part of dpm so it only happens when dpm is enabled.  ulv is a special
> low power state the card can go to in certain idle cases.
> 
> Does the attached patch help?

I changed yet again my card and I'm now running a R9 280X. I'll put the old
card in tomorrow to have a look at it.

So ulv is a feature available on both APUs and 7950 (and some other GPUs). Nice
to know.

But is ulv support truly supposed to be available on Tahiti? In fact, prior to
your patch, why is there already a comment "/* XXX disable for A0 tahiti */" in
drivers/gpu/drm/radeon/si_dpm.c but ulv.supported is set to true anyway just on
the next line (the one you propose to change in your patch)? To me, it's like
saying a thing and doing exactly the opposite at the same time, isn't it? Or is
it because there is a special case (Tahiti) that we should be addressing
identified by the comment that we are not?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20141014/020c7e98/attachment.html>