[PATCH 1/2] drm/radeon: reduce sparse false positive warnings

Alex Deucher alexdeucher at gmail.com
Thu Oct 16 07:34:16 PDT 2014


On Tue, Oct 14, 2014 at 12:25 PM, Michele Curti <michele.curti at gmail.com> wrote:
> include radeon_asic.h header file in the various xxx_dpm.c files
> to reduce sparse false positive warnings. Not so great patch
> in itself, but reducing warning count from 391 to 258 may help
> to see real problems..
>
> Signed-off-by: Michele Curti <michele.curti at gmail.com>

Applied.  thanks!

Alex

> ---
>  drivers/gpu/drm/radeon/btc_dpm.c     | 1 +
>  drivers/gpu/drm/radeon/ci_dpm.c      | 1 +
>  drivers/gpu/drm/radeon/cypress_dpm.c | 1 +
>  drivers/gpu/drm/radeon/ni_dpm.c      | 1 +
>  drivers/gpu/drm/radeon/r600_dpm.c    | 1 +
>  drivers/gpu/drm/radeon/rs780_dpm.c   | 1 +
>  drivers/gpu/drm/radeon/rv6xx_dpm.c   | 1 +
>  drivers/gpu/drm/radeon/rv770_dpm.c   | 1 +
>  drivers/gpu/drm/radeon/si_dpm.c      | 1 +
>  drivers/gpu/drm/radeon/sumo_dpm.c    | 1 +
>  drivers/gpu/drm/radeon/trinity_dpm.c | 1 +
>  11 files changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/radeon/btc_dpm.c b/drivers/gpu/drm/radeon/btc_dpm.c
> index 300d971..d6243f1 100644
> --- a/drivers/gpu/drm/radeon/btc_dpm.c
> +++ b/drivers/gpu/drm/radeon/btc_dpm.c
> @@ -24,6 +24,7 @@
>
>  #include "drmP.h"
>  #include "radeon.h"
> +#include "radeon_asic.h"
>  #include "btcd.h"
>  #include "r600_dpm.h"
>  #include "cypress_dpm.h"
> diff --git a/drivers/gpu/drm/radeon/ci_dpm.c b/drivers/gpu/drm/radeon/ci_dpm.c
> index f5c8c04..11a55e9 100644
> --- a/drivers/gpu/drm/radeon/ci_dpm.c
> +++ b/drivers/gpu/drm/radeon/ci_dpm.c
> @@ -24,6 +24,7 @@
>  #include <linux/firmware.h>
>  #include "drmP.h"
>  #include "radeon.h"
> +#include "radeon_asic.h"
>  #include "radeon_ucode.h"
>  #include "cikd.h"
>  #include "r600_dpm.h"
> diff --git a/drivers/gpu/drm/radeon/cypress_dpm.c b/drivers/gpu/drm/radeon/cypress_dpm.c
> index 47d31e9..9aad032 100644
> --- a/drivers/gpu/drm/radeon/cypress_dpm.c
> +++ b/drivers/gpu/drm/radeon/cypress_dpm.c
> @@ -24,6 +24,7 @@
>
>  #include "drmP.h"
>  #include "radeon.h"
> +#include "radeon_asic.h"
>  #include "evergreend.h"
>  #include "r600_dpm.h"
>  #include "cypress_dpm.h"
> diff --git a/drivers/gpu/drm/radeon/ni_dpm.c b/drivers/gpu/drm/radeon/ni_dpm.c
> index 715b181..6d2f16c 100644
> --- a/drivers/gpu/drm/radeon/ni_dpm.c
> +++ b/drivers/gpu/drm/radeon/ni_dpm.c
> @@ -23,6 +23,7 @@
>
>  #include "drmP.h"
>  #include "radeon.h"
> +#include "radeon_asic.h"
>  #include "nid.h"
>  #include "r600_dpm.h"
>  #include "ni_dpm.h"
> diff --git a/drivers/gpu/drm/radeon/r600_dpm.c b/drivers/gpu/drm/radeon/r600_dpm.c
> index 9c61b74..f6309bd 100644
> --- a/drivers/gpu/drm/radeon/r600_dpm.c
> +++ b/drivers/gpu/drm/radeon/r600_dpm.c
> @@ -24,6 +24,7 @@
>
>  #include "drmP.h"
>  #include "radeon.h"
> +#include "radeon_asic.h"
>  #include "r600d.h"
>  #include "r600_dpm.h"
>  #include "atom.h"
> diff --git a/drivers/gpu/drm/radeon/rs780_dpm.c b/drivers/gpu/drm/radeon/rs780_dpm.c
> index 02f7710..9031f4b 100644
> --- a/drivers/gpu/drm/radeon/rs780_dpm.c
> +++ b/drivers/gpu/drm/radeon/rs780_dpm.c
> @@ -24,6 +24,7 @@
>
>  #include "drmP.h"
>  #include "radeon.h"
> +#include "radeon_asic.h"
>  #include "rs780d.h"
>  #include "r600_dpm.h"
>  #include "rs780_dpm.h"
> diff --git a/drivers/gpu/drm/radeon/rv6xx_dpm.c b/drivers/gpu/drm/radeon/rv6xx_dpm.c
> index e7045b0..6a5c233 100644
> --- a/drivers/gpu/drm/radeon/rv6xx_dpm.c
> +++ b/drivers/gpu/drm/radeon/rv6xx_dpm.c
> @@ -24,6 +24,7 @@
>
>  #include "drmP.h"
>  #include "radeon.h"
> +#include "radeon_asic.h"
>  #include "rv6xxd.h"
>  #include "r600_dpm.h"
>  #include "rv6xx_dpm.h"
> diff --git a/drivers/gpu/drm/radeon/rv770_dpm.c b/drivers/gpu/drm/radeon/rv770_dpm.c
> index 3c76e1d..755a8f9 100644
> --- a/drivers/gpu/drm/radeon/rv770_dpm.c
> +++ b/drivers/gpu/drm/radeon/rv770_dpm.c
> @@ -24,6 +24,7 @@
>
>  #include "drmP.h"
>  #include "radeon.h"
> +#include "radeon_asic.h"
>  #include "rv770d.h"
>  #include "r600_dpm.h"
>  #include "rv770_dpm.h"
> diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si_dpm.c
> index 9e4d5d7..267949a 100644
> --- a/drivers/gpu/drm/radeon/si_dpm.c
> +++ b/drivers/gpu/drm/radeon/si_dpm.c
> @@ -23,6 +23,7 @@
>
>  #include "drmP.h"
>  #include "radeon.h"
> +#include "radeon_asic.h"
>  #include "sid.h"
>  #include "r600_dpm.h"
>  #include "si_dpm.h"
> diff --git a/drivers/gpu/drm/radeon/sumo_dpm.c b/drivers/gpu/drm/radeon/sumo_dpm.c
> index 3f0e8d7..1f8a883 100644
> --- a/drivers/gpu/drm/radeon/sumo_dpm.c
> +++ b/drivers/gpu/drm/radeon/sumo_dpm.c
> @@ -23,6 +23,7 @@
>
>  #include "drmP.h"
>  #include "radeon.h"
> +#include "radeon_asic.h"
>  #include "sumod.h"
>  #include "r600_dpm.h"
>  #include "cypress_dpm.h"
> diff --git a/drivers/gpu/drm/radeon/trinity_dpm.c b/drivers/gpu/drm/radeon/trinity_dpm.c
> index 57f7800..b4ec5c4 100644
> --- a/drivers/gpu/drm/radeon/trinity_dpm.c
> +++ b/drivers/gpu/drm/radeon/trinity_dpm.c
> @@ -23,6 +23,7 @@
>
>  #include "drmP.h"
>  #include "radeon.h"
> +#include "radeon_asic.h"
>  #include "trinityd.h"
>  #include "r600_dpm.h"
>  #include "trinity_dpm.h"
> --
> 2.1.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel


More information about the dri-devel mailing list