[PATCH] drm/dp-helper: Move the legacy helpers to gma500

Daniel Vetter daniel.vetter at ffwll.ch
Thu Oct 23 00:25:29 PDT 2014


On Wed, Oct 22, 2014 at 5:34 PM, Alan Cox <alan at lxorguk.ukuu.org.uk> wrote:
> On Wed, 22 Oct 2014 16:32:52 +0200
> Patrik Jakobsson <patrik.r.jakobsson at gmail.com> wrote:
>
>> On Wed, Oct 22, 2014 at 11:16 AM, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
>> > Except for gma500 all drivers are converted to the new style helpers,
>> > which have much better abstraction of the underlying hw protocols and
>> > already much more helper functions (including the entire mst library)
>> > on top of them. Since no one seems to work on converting gma500 let's
>> > just move the code away so that new drivers don't end up accidentally
>> > using this.
>>
>> Thanks for doing this! I'll CC Alan as well.
>
> Reviewed-by: Alan Cox <alan at linux.intel.com>
>
> Please consider adding an __deprecated marker to one of the top functions
> so it irritates me or someone else into cleaning it up properly

Done. Also added a short FIXME comment so that you don't have to check
with git blame why this is deprecated. And I dropped the EXPORT_SYMBOL
which is no longer needed, too.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dri-devel mailing list