[PATCH 3/4] drm: Simplify return value of drm_get_last_vbltimestamp

Daniel Vetter daniel.vetter at ffwll.ch
Thu Sep 11 04:30:04 PDT 2014


On Thu, Sep 11, 2014 at 1:28 PM, Mario Kleiner
<mario.kleiner.de at gmail.com> wrote:
> On 09/10/2014 05:36 PM, Daniel Vetter wrote:
>>
>> Imo u32 hints at a register value, but in reality all callers only
>> care whether the sampled timestamp is precise or not. So give them
>> just a bool.
>>
>> Also move the declaration out of drmP.h, it's only used in drm_irq.c.
>
>
> All good. Maybe then also remove
>
> EXPORT_SYMBOL(drm_get_last_vbltimestamp);

Oh, I've missed that one when grepping. Will fix when applying.

> in this patch if the method is now static to drm_irq.c ? Up to you.
>
> For all 4 patches...
>
> Reviewed-by: Mario Kleiner <mario.kleiner.de at gmail.com>

Thanks a lot, I plan to send the pull request to Dave tomorrow.
Presuming nothing else fails meanwhile ;-)


More information about the dri-devel mailing list