[PATCH v5 05/11] drm: add Atmel HLCDC Display Controller support

[Thierry Reding]

On Mon, Sep 22, 2014 at 09:18:11PM +0200, Boris BREZILLON wrote:
> On Mon,  8 Sep 2014 10:43:36 +0200 Boris BREZILLON <boris.brezillon at free-electrons.com> wrote:
[...]
> > diff --git a/drivers/gpu/drm/atmel-hlcdc/Kconfig b/drivers/gpu/drm/atmel-hlcdc/Kconfig
> > new file mode 100644
> > index 0000000..6d0d785
> > --- /dev/null
> > +++ b/drivers/gpu/drm/atmel-hlcdc/Kconfig
> > @@ -0,0 +1,13 @@
> > +config DRM_ATMEL_HLCDC
> > +	tristate "DRM Support for ATMEL HLCDC Display Controller"
> > +	depends on DRM && OF && MFD_ATMEL_HLCDC && COMMON_CLK
> 
> I forgot to remove MFD_ATMEL_HLCDC dependency which is now selected...
> 
> 
> > +	select DRM_GEM_CMA_HELPER
> > +	select DRM_KMS_HELPER
> > +	select DRM_KMS_FB_HELPER
> > +	select DRM_KMS_CMA_HELPER
> > +	select DRM_PANEL
> > +	select MFD_ATMEL_HLCDC
> 
> here.

Maybe this was discussed earlier, but can you remind me why this was
done? The changelog says it was to "simplify", but there's been some
recent discussion that select should never be used for symbols that
are user-visible because that can lead to issues.

What were the problems having this as "depends on"?

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140923/1e4fa501/attachment.sig>