[PATCH 1/8] drm/<ttm-based-drivers>: Don't call drm_mmap

[Jerome Glisse]

On Tue, Sep 23, 2014 at 11:53:53PM +0200, David Herrmann wrote:
> Hi
> 
> On Tue, Sep 23, 2014 at 11:38 PM, Jerome Glisse <j.glisse at gmail.com> wrote:
> > On Tue, Sep 23, 2014 at 03:46:47PM +0200, Daniel Vetter wrote:
> >> Really, the legacy buffer api should be dead, especially for all these
> >> newfangled drivers. I suspect this is copypasta from the transitioning
> >> days, which probably originated in radeon.
> >>
> >> Cc: David Airlie <airlied at linux.ie>
> >> Cc: Alex Deucher <alexander.deucher at amd.com>
> >> Cc: "Christian König" <christian.koenig at amd.com>
> >> Cc: David Herrmann <dh.herrmann at gmail.com>
> >> Cc: Rashika <rashika.kheria at gmail.com>
> >> Cc: Josh Triplett <josh at joshtriplett.org>
> >> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> >> Cc: Fabian Frederick <fabf at skynet.be>
> >> Cc: Gerd Hoffmann <kraxel at redhat.com>
> >> Cc: Ben Skeggs <bskeggs at redhat.com>
> >> Cc: Alexandre Courbot <acourbot at nvidia.com>
> >> Cc: Maarten Lankhorst <maarten.lankhorst at canonical.com>
> >> Cc: Christian Engelmayer <cengelma at gmx.at>
> >> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> >
> > I would say NAK as i am pretty sure this break radeon UMS code path.
> > Of course if we have the go ahead to nuke radeon UMS i am more than
> > happy.
> 
> radeon_drv.c says:
>         driver_old.fops.mmap == drm_mmap;
> 
> ..so I don't understand why that would break UMS? Do you use KMS mixed
> with UMS? radeon_mmap() is only used by radeon_driver_kms_fops, which
> is only used by kms_driver. UMS (which I understand as non-KMS in
> radeon case) should not be affected by this.

Oh this might be an heritage of old code in my mind when we had old user
space running on top of KMS, more as a prototype stage and maybe also at
one point the plan was to share the same mmap function so that old code
could use new code cs ioctl.

So yeah this can be nuke sorry for the noise.
> 
> Thanks
> David