[PATCH] drm/exynos: fimd: check whether exynos_drm_crtc_create succeed or not
Gustavo Padovan
gustavo at padovan.org
Wed Apr 1 08:31:40 PDT 2015
Hi Hyungwon,
2015-04-01 Hyungwon Hwang <human.hwang at samsung.com>:
> From the commit "drm/exynos: fix the execution order in FIMD
> initialization" (598285bfdce46d7c47632a2ba4b980f60be4a677), the error
> checking code is removed improperly. This patch fix the regression.
>
> Signed-off-by: Hyungwon Hwang <human.hwang at samsung.com>
> ---
> drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> index 31dfa80..15cee94 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> @@ -1060,6 +1060,8 @@ static int fimd_bind(struct device *dev, struct device *master, void *data)
> ctx->crtc = exynos_drm_crtc_create(drm_dev, ctx->pipe,
> EXYNOS_DISPLAY_TYPE_LCD,
> &fimd_crtc_ops, ctx);
> + if (IS_ERR(ctx->crtc))
> + return PTR_ERR(ctx->crtc);
My current clean up patch set fixes this and I hope it will be merged soon.
It is part of "drm/exynos: remove struct *_win_data abstraction on planes"
patch.
Gustavo
More information about the dri-devel
mailing list