[PATCH RFC 090/111] staging: etnaviv: fix cache cleaning for uncached SHM buffers

Russell King - ARM Linux linux at arm.linux.org.uk
Thu Apr 2 09:22:36 PDT 2015


On Thu, Apr 02, 2015 at 05:30:32PM +0200, Lucas Stach wrote:
> The intention clearly was to do the same thing for WC and UC buffers,
> not for cached ones.

Err, from one of my previous commits:

    staging: etnaviv: fix DMA API usage

    We test for write-combine and non-cacheable mappings before calling the
    DMA API.  This is werid, because non-cacheable mappings are DMA coherent
    by definition, whereas cacheable mappings need cache maintanence
    provided by the DMA API.

    This seems to be a typo: ETNA_BO_CACHED should be used rather than
    ETNA_BO_UNCACHED.

It's utterly senseless to use the DMA API on uncached mappings.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.


More information about the dri-devel mailing list