[PATCH libdrm 07/24] radeon: annotate the private symbols

[Emil Velikov]

On 2 April 2015 at 04:57, Jerome Glisse <j.glisse at gmail.com> wrote:
> On Thu, Apr 02, 2015 at 11:48:25AM +0900, Michel Dänzer wrote:
>> On 02.04.2015 01:15, Emil Velikov wrote:
>> > They are less and easier to track than the public ones.
>>
>> Grammar: s/less/fewer/
>>
>>
>> Other than that, this patch and patch 8 are
>>
>> Acked-by: Michel Dänzer <michel.daenzer at amd.com>
>>
>> though I'm not sure about the impact of Jerome's objection to previous
>> patches on this one.
>
> Yes same apply, adding drm specific define would break my cping of those
> file to my tools. But if Emil feels like adding bofreplay to libdrm i do
> not have any objection.
>
> Thought using some macro trickery inside bof.h this can be work around.
>
Actually the cleanest/quickest solution would be to move bof.[ch] from
libdrm_radeon_la_SOURCES to EXTRA_DIST. This way we won't need any of
these patches,. Plus if one wants to use bof via radeon_cs_gem, they
will have to change one more line (apart from the current CS_BOF_DUMP)
- add the sources into libdrm_radeon_la_SOURCES. I'll add a note about
it next to the define.

As we import bofreplay we can rework things to be more elegant. How
does that sound ?

-Emil