[PATCH 10/10] drm/exynos: atomic dpms support

Joonyoung Shim jy0922.shim at samsung.com
Thu Apr 2 23:46:48 PDT 2015


Hi,
 
>>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
>>> index e71e331..e0b085b 100644
>>> --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
>>> +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
>>> @@ -275,9 +275,6 @@ int exynos_drm_fbdev_init(struct drm_device *dev)
>>>  
>>>  	}
>>>  
>>> -	/* disable all the possible outputs/crtcs before entering KMS mode */
>>> -	drm_helper_disable_unused_functions(dev);
>>> -
>>
>> I think this is not related with atomic dpms support, if this needs,
>> could you make another patch?
> 
> Yes, it is, once you port exynos to use atomic dpms we start getting warning
> from this functions, the correct solution is to remove it. Other subsystems
> followed the same approach.

As i said, the warning comes from changes of this patch.

>From rcar-du driver, it was handled to a separate patch.

http://www.spinics.net/lists/linux-sh/msg40384.html

> 
> I'm sending an updated patch set in a bit.

OK, but i didn't get your updated patch 10/10 yet. Could you resend it?

Thanks.



More information about the dri-devel mailing list