[PATCH 3/3] drm/exynos: mixer: add 2x scaling to mixer_graph_buffer

Tobias Jakobi tjakobi at math.uni-bielefeld.de
Mon Apr 6 10:39:00 PDT 2015


Hello Emil,

Emil Velikov wrote:
> Hi Tobias,
> 
> On 1 April 2015 at 14:29, Tobias Jakobi <tjakobi at math.uni-bielefeld.de> wrote:
>> diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c
>> index 5ab0e32..6822b36 100644
>> --- a/drivers/gpu/drm/exynos/exynos_mixer.c
>> +++ b/drivers/gpu/drm/exynos/exynos_mixer.c
> 
>> @@ -528,9 +552,8 @@ static void mixer_graph_buffer(struct mixer_context *ctx, int win)
>>                 fmt = ARGB8888;
>>         }
>>
>> -       /* 2x scaling feature */
>> -       x_ratio = 0;
>> -       y_ratio = 0;
>> +       /* check if mixer supports requested scaling setup */
>> +       if (mixer_setup_scale(plane, &x_ratio, &y_ratio)) return;
>>
> Having return on the same line as the if statement will make
> checkpatch.pl unhappy :-(
right, I'm going to fix this and resend the series.

With best wishes,
Tobias



More information about the dri-devel mailing list