[RFC 3/6] drm/exynos: introduce struct exynos_drm_plane_config

Tobias Jakobi tjakobi at math.uni-bielefeld.de
Thu Apr 16 07:29:06 PDT 2015


Hello!

On 2015-04-15 22:33, Gustavo Padovan wrote:
>> > As a follow up of my atomic series I started cleaning up exynos drm a bit more
>> > and right now I'm removing most of struct exynos_drm_plane. Most of the plane
>> > information there is also present in plane->state thus I'm basically removing
>> > all the duplicated information there.
>> Sounds like a good plan.
>> 
>> 
>> > That said, I think we avoid creating exynos_drm_plane_config and stuff
>> > everything directly in struct exynos_drm_plane, it will be quite small and
>> > easier to manipulate.
>> So that would imply that we then just have:
>> int exynos_plane_init(struct drm_device *dev, struct exynos_drm_plane
>> *exynos_plane);
>> 
>> Correct?
> 
> Correct, passing exynos_drm_plane simplifies things a lot for us.
> 
>> 
>> Anyway, I'm going to wait then until the cleanups are posted and 
>> rebase
>> this series onto it.
> 
> Right, I'll probably have that the next week or the other one, I'm 
> currently
> working on some testing scripts to speed up my testing and make sure 
> I'm not
> breaking anything.
Cool, take your time. And sorry that I haven't provided any feedback on 
the atomic patches yet. Something urgent came up that day and I haven't 
found enough time since then.

With best wishes,
Tobias



More information about the dri-devel mailing list