[PATCH 10/11] drm/i915: Reprobe connectors if vga_switcheroo handler registers late

Lukas Wunner lukas at wunner.de
Tue Apr 21 05:16:56 PDT 2015


Hi Chris,

On Tue, Apr 21, 2015 at 12:50:10PM +0100, Chris Wilson wrote:
> On Sun, Apr 19, 2015 at 05:01:17PM +0200, Lukas Wunner wrote:
> > +cleanup_gem:
> > +	DRM_ERROR("failed to reinitialize fbdev\n");
> > +	mutex_lock(&dev->struct_mutex);
> > +	i915_gem_cleanup_ringbuffer(dev);
> > +	i915_gem_context_fini(dev);
> > +	mutex_unlock(&dev->struct_mutex);
> 
> This is a bit random since you don't initialize GEM here and presumably
> the GPU is still available even if it has no outputs.

Hm, I copied this verbatim from i915_dma.c:i915_load_modeset_init(),
I was under the impression that this is required if fbdev initialization
failed. Am I missing something?

Thanks,

Lukas


More information about the dri-devel mailing list