[PATCH 2/2] Fix one warning (v2)

Emil Velikov emil.l.velikov at gmail.com
Tue Apr 28 09:26:07 PDT 2015


On 28 April 2015 at 15:43, Jan Vesely <jan.vesely at rutgers.edu> wrote:
> On Mon, 2015-04-27 at 10:29 +0800, Jammy Zhou wrote:
>> xf86drm.c:356:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
>>   group = (serv_group >= 0) ? serv_group : DRM_DEV_GID;
>>   ^
>>
>> v2: do 'int' cast to fix the warning
>>
>> Signed-off-by: Jammy Zhou <Jammy.Zhou at amd.com>
>
> FWIW
> Reviewed-by: Jan Vesely <jan.vesely at rutgers.edu>
>
> Emil, are you OK with this approach?
>
Ideally one of the old school devs will chip in, but this looks good imho.
Lets give it a week or so for other interested parties to chip-in.

-Emil


More information about the dri-devel mailing list