linux-4.1-rc1/drivers/gpu/drm/msm/dsi/dsi_host.c:1799: possible missing break ?

[Hai Li]

Yes, this is a bug in DSI driver. I have sent a patch to fix it.
http://lists.freedesktop.org/archives/dri-devel/2015-April/081893.html

Sorry for any inconvenience it caused.

Hai


-----Original Message-----
From: dri-devel [mailto:dri-devel-bounces at lists.freedesktop.org] On Behalf Of David Binderman
Sent: Monday, April 27, 2015 1:59 AM
To: airlied at linux.ie; dri-devel at lists.freedesktop.org
Subject: linux-4.1-rc1/drivers/gpu/drm/msm/dsi/dsi_host.c:1799: possible missing break ?

Hello there,

[linux-4.1-rc1/drivers/gpu/drm/msm/dsi/dsi_host.c:1799] -> [linux-4.1-rc1/drivers/gpu/drm/msm/dsi/dsi_host.c:1802]: (warning) Variable 'ret' is reassigned a value before the old one has been used. 'break;' missing?

    switch (cmd) {
    case MIPI_DSI_RX_ACKNOWLEDGE_AND_ERROR_REPORT:
        pr_err("%s: rx ACK_ERR_PACLAGE\n", __func__);
        ret = 0;
    case MIPI_DSI_RX_GENERIC_SHORT_READ_RESPONSE_1BYTE:
    case MIPI_DSI_RX_DCS_SHORT_READ_RESPONSE_1BYTE:
        ret = dsi_short_read1_resp(buf, msg);
        break;

Regards

David Binderman

 		 	   		  
_______________________________________________
dri-devel mailing list
dri-devel at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel