[PATCH 1/4] drm: consolidate common list implementations

Emil Velikov emil.l.velikov at gmail.com
Wed Apr 29 12:26:22 PDT 2015


On 24/04/15 15:13, Alex Deucher wrote:
> This is used by radeon and freedreno and will be used
> by amdgpu.  I looked at switching to libdrm_lists.h,
> but it's pretty horrible.  E.g., DRMLISTFOREACHENTRYSAFE.
> 
It does have one advantage though - it's typeless. Thus it allows
nouveau and intel to have their custom list implementations. For example
 - struct nouveau_list (plain double list)
 - struct {mem_,}block (double list with some extra bookkeeping)

This change might cause small issues with Jerome's bof replay tool
(joujou), although I should have it merged with libdrm as this lands (or
shortly after).

With the comments sent out earlier for 3/4 (v4) and 4/4(v2), feel free
to add Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>, fwiw.

Thanks
Emil



More information about the dri-devel mailing list