[PATCH] drm/atomic: Call ww_acquire_done after check phase is complete

Daniel Vetter daniel.vetter at ffwll.ch
Wed Aug 5 08:03:46 PDT 2015

On Wed, Aug 5, 2015 at 4:57 PM, Maarten Lankhorst
<maarten.lankhorst at linux.intel.com> wrote:
> Op 05-08-15 om 15:08 schreef Daniel Vetter:
>> We want to make sure that no one tries to acquire more locks and
>> states, and ww mutexes provide debug facilities for that. So use them.
>> Cc: Rob Clark <robdclark at gmail.com>
>> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
>> ---
>>  drivers/gpu/drm/drm_atomic.c | 2 ++
>>  1 file changed, 2 insertions(+)
> I like the idea, played with the thought myself, but I think it might need to be slightly less strict for transitional drivers.

What would blow up? This should only be called fairly late in the
transition when most of the atomic handling is correctly done. And
i915 is probably the most extreme example of a conversion, so if it
works out for us I think everyone else should be fine too.

Generally drivers only started to do fancy stuff with get_*_state once
converted to atomic to start exploiting it, not before the transition
is completed. i915 is different since we have a lot of our own modeset
code ...
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

More information about the dri-devel mailing list