[PATCH] drm/exynos/fimc: fix runtime pm support

Inki Dae inki.dae at samsung.com
Thu Aug 6 04:57:20 PDT 2015


On 2015년 08월 06일 19:13, Marek Szyprowski wrote:
> Hello,
> 
> On 2015-04-09 10:46, Marek Szyprowski wrote:
>> Once pm_runtime_set_active() gets called, the kernel assumes that given
>> device has already enabled runtime pm and will call pm_runtime_suspend()
>> without matching pm_runtime_resume(). In case of DRM FIMC IPP driver,
>> this will result in calling clk_disable() without respective call to
>> clk_enable(). This patch removes call to pm_runtime_set_active() to
>> ensure that pm_runtime_suspend/resume calls will match.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski at samsung.com>
> 
> Gentle ping...

Sorry, I missed it. Merged.

Thanks,
Inki Dae

> 
>> ---
>>   drivers/gpu/drm/exynos/exynos_drm_fimc.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
>> b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
>> index 842d6b8dc3c4..2a652359af64 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
>> @@ -1745,7 +1745,6 @@ static int fimc_probe(struct platform_device *pdev)
>>       spin_lock_init(&ctx->lock);
>>       platform_set_drvdata(pdev, ctx);
>>   -    pm_runtime_set_active(dev);
>>       pm_runtime_enable(dev);
>>         ret = exynos_drm_ippdrv_register(ippdrv);
> 
> Best regards



More information about the dri-devel mailing list