[PATCH 2/6] drm/atomic: pass old crtc state to atomic_begin/flush.

Tomi Valkeinen tomi.valkeinen at gmail.com
Tue Aug 4 23:18:29 PDT 2015


Hi,

On 21/07/15 14:28, Maarten Lankhorst wrote:
> In intel it's useful to keep track of some state changes with old
> crtc state vs new state, for example to disable initial planes or
> when a modeset's prevented during fastboot.
> 
> Cc: dri-devel at lists.freedesktop.org
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> ---
>  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c |  6 ++++--
>  drivers/gpu/drm/drm_atomic_helper.c            |  8 ++++----
>  drivers/gpu/drm/drm_plane_helper.c             |  4 ++--
>  drivers/gpu/drm/i915/intel_display.c           | 10 ++++++----
>  drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c       |  6 ++++--
>  drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c       |  6 ++++--
>  drivers/gpu/drm/rcar-du/rcar_du_crtc.c         |  6 ++++--
>  drivers/gpu/drm/sti/sti_drm_crtc.c             |  6 ++++--
>  drivers/gpu/drm/tegra/dc.c                     |  6 ++++--
>  include/drm/drm_crtc_helper.h                  |  6 ++++--
>  10 files changed, 40 insertions(+), 24 deletions(-)

Looks like this broke omapdrm in linux-next:

drivers/gpu/drm/omapdrm/omap_crtc.c:470:2: error: initialization from
incompatible pointer type [-Werror]
drivers/gpu/drm/omapdrm/omap_crtc.c:470:2: error: (near initialization
for ‘omap_crtc_helper_funcs.atomic_begin’) [-Werror]
drivers/gpu/drm/omapdrm/omap_crtc.c:471:2: error: initialization from
incompatible pointer type [-Werror]
drivers/gpu/drm/omapdrm/omap_crtc.c:471:2: error: (near initialization
for ‘omap_crtc_helper_funcs.atomic_flush’) [-Werror]

 Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20150805/60ee84d1/attachment.sig>


More information about the dri-devel mailing list