[PATCH 1/3] remove usage of 'c_plusplus' preprocessor macro

[Chris Wilson]

On Fri, Aug 07, 2015 at 02:38:49PM +0200, Thierry Reding wrote:
> On Fri, Aug 07, 2015 at 03:16:10PM +0300, Tapani Pälli wrote:
> > 
> > 
> > On 08/07/2015 03:11 PM, Thierry Reding wrote:
> > >On Fri, Aug 07, 2015 at 10:37:56AM +0300, Tapani Pälli wrote:
> > >>Use only __cplusplus which is supported by the C++ standard.
> > >>
> > >>Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
> > >>---
> > >>  libkms/libkms.h | 4 ++--
> > >>  xf86drm.h       | 4 ++--
> > >>  xf86drmMode.h   | 4 ++--
> > >>  3 files changed, 6 insertions(+), 6 deletions(-)
> > >
> > >This looks fine to me, I can't find any mention of c_plusplus on the
> > >internet. Let's see what Laurent says, who added this in commit:
> > >
> > >	commit 9fa4a4b1a894fa8fffe2075bc3376b7fa5e18104
> > >	Author: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > >	Date:   Thu Nov 1 09:40:30 2012 +0000
> > >	
> > >	    kms: Make libkms.h usable in C++
> > >	
> > >	    Wrap the header in extern "C" { ... };.
> > >	
> > >	    Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > >	    Reviewed-by: Jakob Bornecrantz <wallbraker at gmail.com>
> > >
> > >Oh... looks like Laurent's changes might have been copy/paste from your
> > >earlier commit:
> > 
> > :) yeah, I'm not the source for this evil though, I recall this addition was
> > made during the review!
> 
> Indeed, looks like your original post:
> 
> 	http://lists.freedesktop.org/archives/dri-devel/2011-September/014552.html
> 
> didn't have it. Since Chris amended the commit, perhaps he had a reason
> to add it. Chris?

Just cargo-culting.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre