[PATCH 3/3] modeprint: cleanup, remove compile warnings

Emil Velikov emil.l.velikov at gmail.com
Fri Aug 7 08:05:59 PDT 2015


On 7 August 2015 at 08:37, Tapani Pälli <tapani.palli at intel.com> wrote:
> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
> ---
>  tests/modeprint/modeprint.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tests/modeprint/modeprint.c b/tests/modeprint/modeprint.c
> index e6c6553..5e953f7 100644
> --- a/tests/modeprint/modeprint.c
> +++ b/tests/modeprint/modeprint.c
> @@ -61,6 +61,7 @@ static const char* getConnectionText(drmModeConnection conn)
>                 return "connected";
>         case DRM_MODE_DISCONNECTED:
>                 return "disconnected";
> +       case DRM_MODE_UNKNOWNCONNECTION:
>         default:
>                 return "unknown";
>         }
> @@ -124,9 +125,6 @@ static int printProperty(int fd, drmModeResPtr res, drmModePropertyPtr props, ui
>                 }
>
>         } else {
> -               if (!strncmp(props->name, "DPMS", 4))
> -                       ;
> -
I've never bothered checking if this hunk was useful at some point. If
you had can you add a line in the commit log.

Regardless, the series is
Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

Thanks for sticking with my suggestion and killing off the c_plusplus fossil.
-Emil


More information about the dri-devel mailing list