[PATCH 08/13] drm/irq: Check for valid VBLANK before dereference
daniel at ffwll.ch
Thu Aug 13 06:05:46 PDT 2015
On Thu, Aug 13, 2015 at 11:20:05AM +0200, Thierry Reding wrote:
> On Wed, Aug 12, 2015 at 05:40:11PM +0200, Daniel Vetter wrote:
> > On Wed, Aug 12, 2015 at 05:00:30PM +0200, Thierry Reding wrote:
> > > From: Thierry Reding <treding at nvidia.com>
> > >
> > > When accessing the array of per-CRTC VBLANK structures we must always
> > > check that the index into the array is valid before dereferencing to
> > > avoid crashing.
> > >
> > > Signed-off-by: Thierry Reding <treding at nvidia.com>
> > This misses vblank_reset (I guess that function is newer than your
> > patches). Can you please do a follow-up? I merged this one meanwhile.
> We only have drm_crtc_vblank_reset(), in which case there's no need to
> check the index because it's obtained directly from a struct drm_crtc *
> and hence will be valid.
Right, I overlooked that.
Software Engineer, Intel Corporation
More information about the dri-devel