[PATCH 1/5] drm: add interface to get drm devices on the system v2
emil.l.velikov at gmail.com
Thu Aug 13 06:58:03 PDT 2015
On 13 August 2015 at 04:33, Jammy Zhou <Jammy.Zhou at amd.com> wrote:
> From: Emil Velikov <emil.l.velikov at gmail.com>
> For mutiple GPU support, the devices on the system should be enumerated
> to get necessary information about each device, and the drmGetDevices
> interface is added for this. Currently only PCI devices are supported for
> the enumeration.
If there are any other devices they will still be counted when
drmGetDevices(NULL, 0)... Is that intentional ?
> +static int drmParsePciDeviceInfo(const char *config,
> + drmPciDeviceInfoPtr device)
> + if (config == NULL)
> + return -EINVAL;
> + device->vendor_id = config | (config << 8);
> + device->device_id = config | (config << 8);
> + device->revision_id = config;
> + device->subvendor_id = config | (config << 8);
> + device->subdevice_id = config | (config << 8);
Something funny is happening here - on my intel system vendor_id is
reported as 0xff86, instead of 0x8086. Subvendor/device are also
messed up - ffaa and ffda instead of 17aa + 21da.
One could bikeshed on the de-duplication error path(s), but
considering that things work and there are no leaks we can leave that
for some other day.
More information about the dri-devel