[PATCH] drm/nouveau/fifo: fix simple_return.cocci warnings

kbuild test robot fengguang.wu at intel.com
Sat Aug 15 08:56:27 PDT 2015


drivers/gpu/drm/nouveau/nvkm/engine/fifo/g84.c:396:1-4: WARNING: end returns can be simpified

 Simplify a trivial if-return sequence.  Possibly combine with a
 preceding function call.

Generated by: scripts/coccinelle/misc/simple_return.cocci

Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
---

 g84.c |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

--- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/g84.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/g84.c
@@ -393,12 +393,8 @@ g84_fifo_context_ctor(struct nvkm_object
 	if (ret)
 		return ret;
 
-	ret = nvkm_gpuobj_new(nv_object(base), nv_object(base), 0x0100,
+	return nvkm_gpuobj_new(nv_object(base), nv_object(base), 0x0100,
 			      0x100, NVOBJ_FLAG_ZERO_ALLOC, &base->ramfc);
-	if (ret)
-		return ret;
-
-	return 0;
 }
 
 static struct nvkm_oclass


More information about the dri-devel mailing list