[PATCH RFC v3 3/7] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

Jyri Sarha jsarha at ti.com
Mon Aug 17 05:59:21 PDT 2015

On 08/17/15 10:57, Jyri Sarha wrote:
> Missed one commet first time around...
> On 08/14/15 19:18, Mark Brown wrote:
>> On Fri, Aug 14, 2015 at 12:30:41PM +0300, Jyri Sarha wrote:
> ...
>>> +/* HDMI codec initalization data */
>>> +struct hdmi_codec_pdata {
>>> +    struct device *dev; /* The HDMI encoder registering the codec */
>> Shouldn't this just be dev->parent?
> No. The HDMI encoder device is the parent for HDMI-codec.
> The patch you took in in the last round uses the ASoC component drivers
> parent's of-node if the component driver does not have one itself. In
> this case the phandle in the binding points to the HDMI encoder's node,
> which is the parent of the HDMI codec.

After reading the comment again I see now what you meant.

Yes, I can extract the encoder device from the dev->parent pointer. No 
need to have it in pdata.


More information about the dri-devel mailing list