[PATCH 3/6] xf86drmMode: Make atomic request structures visible

Pekka Paalanen ppaalanen at gmail.com
Thu Aug 20 23:44:42 PDT 2015


On Fri, 21 Aug 2015 15:06:58 +0900
Hyungwon Hwang <human.hwang at samsung.com> wrote:

> Hi Emil,
> 
> On Thu, 20 Aug 2015 17:23:09 +0100
> Emil Velikov <emil.l.velikov at gmail.com> wrote:
> 
> > On 19 August 2015 at 01:58, Hyungwon Hwang <human.hwang at samsung.com>
> > wrote:
> > > This patch makes 'struct _drmModeAtomicReqItem' and 'struct
> > > _drmModeAtomicReq' visible from outside. This is needed for
> > > userspace applications to use those structures when calling
> > > drmModeAtomicCommit().

Yeah, this sounds like a very bad idea.


Thanks,
pq

> > >
> > Hmmm what is missing in the current API, that one needs direct access
> > to the structs ? If we expose these to the user we'll be putting a
> > (ABI) hedgehog down our pants (i.e. it might be ok, but will likely
> > result in a very painful experience).
> 
> I also agree with you. I think I should drop this patch, and find
> another way for modetest.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20150821/f3c89b23/attachment.sig>


More information about the dri-devel mailing list