[Intel-gfx] [PATCH] drm/mm: Do DRM_MM_CREATE_TOP adj_start calculation after color_adjust

Daniel Vetter daniel at ffwll.ch
Tue Aug 25 01:24:53 PDT 2015

On Sun, Aug 16, 2015 at 08:52:54AM +0100, Chris Wilson wrote:
> On Sun, Aug 16, 2015 at 04:02:28AM +0100, Michel Thierry wrote:
> > The adj_start calculation for DRM_MM_CREATE_TOP should happen after
> > mm->color_adjust. There was an inconsistency between
> > drm_mm_insert_helper_range
> > and drm_mm_insert_helper, as the later was already updating after
> > color_adjust.
> > 
> > Didn't spot it before, as color_adjust is only done in systems without
> > LLC. But I'm not aware of anybody using this test case yet.
> > 
> > Signed-off-by: Michel Thierry <michel.thierry at intel.com>
> I sent this patch a few years ago, when I was using a top-down
> allocator before llc and I have a similar patch in my tree which I kept
> meaning to polish up and warn you about before PIN_HIGH.
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Applied to drm-misc, thanks.
Daniel Vetter
Software Engineer, Intel Corporation

More information about the dri-devel mailing list