[PATCH 1/2] drm/exynos: remove legacy ->suspend()/resume()

Gustavo Padovan gustavo at padovan.org
Wed Aug 26 08:50:44 PDT 2015


Hi,

What about this patch? We need it to avoid the WARN_ON added by patch
2/2 that was already picked up by Daniel.

	Gustavo

2015-08-13 Gustavo Padovan <gustavo at padovan.org>:

> From: Gustavo Padovan <gustavo.padovan at collabora.co.uk>
> 
> These legacy helpers should only be used by shadow-attaching drivers.
> KMS drivers has its own way to handle suspend/resume and don't need to
> use these two helpers.
> 
> Signed-off-by: Gustavo Padovan <gustavo.padovan at collabora.co.uk>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_drv.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> index f1d6966..9bcf679 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> @@ -280,8 +280,6 @@ static struct drm_driver exynos_drm_driver = {
>  	.driver_features	= DRIVER_MODESET | DRIVER_GEM | DRIVER_PRIME,
>  	.load			= exynos_drm_load,
>  	.unload			= exynos_drm_unload,
> -	.suspend		= exynos_drm_suspend,
> -	.resume			= exynos_drm_resume,
>  	.open			= exynos_drm_open,
>  	.preclose		= exynos_drm_preclose,
>  	.lastclose		= exynos_drm_lastclose,
> -- 
> 2.1.0
> 


More information about the dri-devel mailing list