[PATCH 00/14] drm/exynos: rewrite fimg2d error handling
Emil Velikov
emil.l.velikov at gmail.com
Thu Aug 27 10:21:36 PDT 2015
Hi Tobias,
On 24 August 2015 at 15:13, Tobias Jakobi <tjakobi at math.uni-bielefeld.de> wrote:
> Hello,
>
> during the discussion about the last patchset touching the
> fimg2d code, it became apparent that the error handling for
> the command submission is currently unsatisfactory.
>
> This series rewrites the handling. All functions that submit
> command buffers now first check if enough space is available
> and only then proceed to build the command buffers.
>
> In particular the command buffer is no longer left in a
> half-finished state, since parameters passed to the functions
> are now validated before command submission. For this some
> validation functions are introduced.
>
> This should also increase performance if the bottleneck is
> the submission part, since adding commands to the buffer
> is now more lightweight.
>
> Last but not least some prefix was added to messages printed
> by fprintf and printf, and the G2D context struct was moved
> out of the public header.
>
>
Thanks for going with my earlier suggestion and untangling all this.
I've went through the lot and it looks great afaict. Fwiw for the series
Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
As pretty much none of this is hardware specific and/or requires
additional knowledge of the kernel module I'm inclined to pull this in
even if we don't get too many reviewers. We better keep it around for
a couple of weeks in case others are swamped with unrelated work atm,
yet willing to take a look.
Cheers,
Emil
More information about the dri-devel
mailing list