[PATCH v3 3/3] drm/rockchip: remove rockchip_drm_encoder_get_mux_id

Philipp Zabel p.zabel at pengutronix.de
Fri Aug 28 06:27:53 PDT 2015


Hi Heiko, Mark, Yakir,

thank you for review & testing!

Am Freitag, den 28.08.2015, 11:18 +0800 schrieb Yakir Yang:
> Actually, I do feel some strange limit with this change.
> 
> If we take the endpoint id as the vop id, then we must ensure the
> remote point order in dtsi file.
>                                  hdmi_in_vopb: endpoint at 0 {
>                                          reg = <0>;
>                                          remote-endpoint = <&vopb_out_hdmi>;
>                                  };
>                                  hdmi_in_vopl: endpoint at 1 {
>                                          reg = <1>;
>                                          remote-endpoint = <&vopl_out_hdmi>;
>                                  };
> 
> This is strange limite, don't you think?

Not the order, but the reg property must be set as documented in
Documentation/devicetree/bindings/video/dw_hdmi-rockchip.txt:

- ports: contain a port node with endpoint definitions as defined in
  Documentation/devicetree/bindings/media/video-interfaces.txt. For
  vopb,set the reg = <0> and set the reg = <1> for vopl.

This has been exactly the same before.

regards
Philipp



More information about the dri-devel mailing list