[PATCH 12/29] drm/armada: Drop struct_mutex from cursor paths

Russell King - ARM Linux linux at arm.linux.org.uk
Thu Dec 3 08:08:45 PST 2015


On Mon, Nov 23, 2015 at 10:32:45AM +0100, Daniel Vetter wrote:
> @@ -957,11 +955,9 @@ static int armada_drm_crtc_cursor_move(struct drm_crtc *crtc, int x, int y)
>  	if (!dcrtc->variant->has_spu_adv_reg)
>  		return -EFAULT;
>  
> -	mutex_lock(&dev->struct_mutex);
>  	dcrtc->cursor_x = x;
>  	dcrtc->cursor_y = y;
>  	ret = armada_drm_crtc_cursor_update(dcrtc, false);
> -	mutex_unlock(&dev->struct_mutex);
>  
>  	return ret;
>  }

drivers/gpu/drm/armada/armada_crtc.c: In function 'armada_drm_crtc_cursor_move':
drivers/gpu/drm/armada/armada_crtc.c:916:21: warning: unused variable 'dev' [-Wunused-variable]

Shall I add to your patch a change to remove that variable too? :)

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.


More information about the dri-devel mailing list