[PATCH v2 2/4] drm/exynos: dp: fix wrong return type
Inki Dae
inki.dae at samsung.com
Mon Dec 7 04:52:36 PST 2015
This patch fixes wrong return type when dt binding of bridge device
failed.
If a board has a bridge device then of_graph_get_remote_port_parent
function shouldn't be NULL. So this patch will return a proper error
type so that the deferred probe isn't triggered.
Changelog v2:
- return -EINVAL if getting a port node failed.
Signed-off-by: Inki Dae <inki.dae at samsung.com>
Reviewed-by: Javier Martinez Canillas <javier at osg.samsung.com>
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c
index 60260a0..aeee60a 100644
--- a/drivers/gpu/drm/exynos/exynos_dp_core.c
+++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
@@ -1437,8 +1437,10 @@ static int exynos_dp_probe(struct platform_device *pdev)
of_node_put(bridge_node);
if (!dp->ptn_bridge)
return -EPROBE_DEFER;
- } else
- return -EPROBE_DEFER;
+ } else {
+ DRM_ERROR("no port node for bridge device.\n");
+ return -EINVAL;
+ }
}
out:
--
1.9.1
More information about the dri-devel
mailing list