[PATCH v2 14/22] drm/exynos: fimd: fix dma burst size setting for small plane size

[Daniel Stone]

Hi Inki,

On 10 December 2015 at 12:59, Marek Szyprowski <m.szyprowski at samsung.com> wrote:
> On 2015-12-10 12:35, Inki Dae wrote:
>> 2015년 11월 30일 22:53에 Marek Szyprowski 이(가) 쓴 글:
>>> This patch fixes trashed display of buffers cropped to very small width.
>>> Even if DMA is unstable and causes tearing when changing the burst size,
>>> it is still better than displaying a garbage.
>>
>> It seems that this patch is different from above description. I think
>> below patch is just cleanup,
>> which passes each member necessary instead of passing a drm_framebuffer
>> object.
>
>
> Please note the last chunk of this patch. After applying it width is
> taken from state->src.w instead of fb->width. If you want, I can split
> this patch into 2 parts - one cleanup without functional change, and
> second, replacement of fb->width with state->src.w.

As Marek says:
http://lists.freedesktop.org/archives/dri-devel/2015-November/094321.html

It fixes the case where state->src.w (what we're actually scanning
out) < MIN_FB_WIDTH_FOR_16WORD_BURST < fb->width (total size of
allocated buffer). Quite subtle, but also correct.

Cheers,
Daniel