[PATCH 2/2] drm/dp/mst: always send reply for UP request

[Wentland, Harry]

Thanks, Dave.

Do you have an example when the up reply would be too big to fit into one sideband message? We don't expect that to happen.

Mykola, can you see if Dave's patch is a good alternative to your patch?

Harry



On Fri, Dec 18, 2015 at 7:57 PM -0800, "Dave Airlie" <airlied at gmail.com<mailto:airlied at gmail.com>> wrote:

On 19 December 2015 at 08:14, Harry Wentland <harry.wentland at amd.com> wrote:
> From: Mykola Lysenko <Mykola.Lysenko at amd.com>
>
> We should always send reply for UP request in order
> to make downstream device clean-up resources appropriately.
>
> Issue was that reply for UP request was sent only once.

What happens though if the up reply is too big and needs to be cut into pieces,

Since the return value of process_single_tx_qlock is
-value - errno.
0 - part of msg sent
1 - all of msg sent

Does the attached patch make any difference?

It handles the queue like the down queue.

Dave.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20151219/5827d2e0/attachment-0001.html>