[PATCH] drm/exynos: fix kernel panic issue at drm releasing

Daniel Stone daniel at fooishbar.org
Thu Dec 24 05:32:51 PST 2015


Hi Inki,

On 24 December 2015 at 09:10, Inki Dae <inki.dae at samsung.com> wrote:
> +void exynos_drm_crtc_cancel_page_flip(struct drm_crtc *crtc)
> +{
> +       struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(crtc);
> +       unsigned long flags;
> +
> +       spin_lock_irqsave(&crtc->dev->event_lock, flags);
> +       exynos_crtc->event = NULL;
> +       spin_unlock_irqrestore(&crtc->dev->event_lock, flags);
> +}

This will leak the event and event space; you should call
event->base.destroy() here. With that fixed:
Reviewed-by: Daniel Stone <daniels at collabora.com>

Cheers,
Daniel


More information about the dri-devel mailing list